Skip to content

Fixed bug that broke silent registration when using a validator #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

erikras
Copy link
Member

@erikras erikras commented Apr 1, 2020

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #336 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #336   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          568       569    +1     
  Branches       119       120    +1     
=========================================
+ Hits           568       569    +1     
Impacted Files Coverage Δ
src/FinalForm.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64225dd...4f1edb9. Read the comment docs.

@erikras erikras merged commit 739f7e5 into master Apr 1, 2020
@erikras erikras deleted the silent-registration-with-validator branch April 1, 2020 15:29
@erikras
Copy link
Member Author

erikras commented Apr 1, 2020

Published in v4.19.1.

@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 16.13.X warning when Field has validator
1 participant