[Request] Presets - Only joystick settings should be saved

[KlaviculaAG]

In another issue report, a user says that volume of game cybotsam disappears after round starts. Was discovered that cps2's volume is configured with same buttons the normal control. But how this occured? I think the reason is: "Presets (controls)". The problem is the presets save various configurations instead only save joystick settings.
E.g. A another bug that i discovered:
Use a fresh instalation without any config/preset.

Play sfiii3 and change region to "Oceania*" (or another that not used in FBNeo) with dip switchs.
Now, config your controls. click on "save preset".
Close game and play another one for cps3.

Here my results:
sfiii2h (hispanic): loaded with oceania region
sfiiia (asia): loaded with oceania region
jojou (usa): loaded with oceania region
jojobaj (japan): loaded with oceania region
redearth (europe): loaded with oceania region + "no cd-rom drive" bug

if just plays redearth, config controls and save preset (no changes in region)...
sfiii3jr1 (japan): loaded with euro "no cd" region
sfiii2 (usa): loaded with euro region
sfiiij (japan): loaded with euro region
jojoa (asia): loaded with euro "debug version" region
jojobanrb hack (japan): loaded with euro "debug version" region

Sorry my broken english. Thanks.

Attachments
Screenshots and two preset (cps.ini) files - "how is saved + how should be saved"

screenshots_redearth no changes.zip

screenshots_sfiii3+oceania_region.zip

two_presets.zip

[barbudreadmon]

Yes, presets contain all input-related settings (including volume up/down and dipswitches).
Removing this behavior is not advisable, users are using this to share settings over several games from the same board, a common case is forcing unibios/aes on neogeo games by default.

[dinkc64]

Well, preset save is supposed to work like this (save dips). But, maybe we should make an option:
Save Preset [ ] with dips checkbox
It's an idea, what do you think?

best regards,

• dink

[dinkc64]

At first, I thought it would be a good idea to remove volume control buttons. Instead maybe we should have a different identifier for such buttons. (instead of fire internal identifier) to avoid any confusion in the future w/presets. This way it will never get confused with a fire button in the future.

best regards,

• dink

[dinkc64]

So, the good news: volume buttons will never get confused for player buttons again, ever :)

a71c3a0

best regards,

• dink

[barbudreadmon]

It's an idea, what do you think?

Well, i don't know, ultimately it only solves the problem partially, the real problem is that games within a same preset can have different input/dip lists, and there are probably just as many problems having presets sharing inputs without dips.
Tbh i just think presets are something that should be used carefully.

I'm just wondering about one thing :

struct BurnDriver BurnDrvPopbounc = {
	"popbounc", NULL, "neogeo", NULL, "1997",
	"Pop 'n Bounce / Gapporin\0", NULL, "Video System Co.", "Neo Geo MVS",
	L"Pop 'n Bounce\0\u30AC\u30C3\u30DD\u30EA\u30F3\0", NULL, NULL, NULL,
	BDF_GAME_WORKING | BDF_HISCORE_SUPPORTED, 2, HARDWARE_PREFIX_CARTRIDGE | HARDWARE_SNK_NEOGEO | HARDWARE_SNK_PADDLE, GBF_PUZZLE, 0,
	NULL, popbouncRomInfo, popbouncRomName, NULL, NULL, NULL, NULL, neopaddleInputInfo, neopaddleDIPInfo,
	NeoInit, NeoExit, NeoFrame, NeoRender, NeoScan, &NeoRecalcPalette,
	0x1000,	304, 224, 4, 3
};

=> can you think of a good way to extract the "neopaddle" string from the input/dip lists programmatically ? Maybe those strings could be appended to the preset name ? Like having a neogeo_neopaddle_neopaddle.ini containing input+dip, or 2 neogeo_neopaddle.ini files in distinct folders, one with input and one with dip.

[dinkc64]

well, I never really had a problem with this, though, when I did (related to dips) -- I'd just edit the dips out of the saved preset.
but, we could check for HARDWARE_SNK_PADDLE

[barbudreadmon]

I agree careful usage with manual edition is the correct method to handle presets, but that might not be so obvious for the average user.

we could check for HARDWARE_SNK_PADDLE

Well, the neopaddle thing was just an example, the problem is that a preset is guaranteed 100% valid only for a specific input configuration, so adding an identifier for the actual input configuration as part of the preset filename might be nice. Using hardware flags wouldn't be a global solution. I think cpp's reflection could get us there, but it's probably not compatible with FBNeo's coding standards.

[KlaviculaAG]

Thx for volume fix