Repository navigation
fix(vscode): use theme colours in the canvas preview - #3331
Merged
markscott-ms merged 1 commit intoOct 14, 2026
Merged
Conversation
Replace fixed colours in the canvas nodes, edges, and panels with --vscode-* variables so the preview follows the editor theme. Fixes #3076 Signed-off-by: Mangesh Raut <mbr63drexel@gmail.com> Co-authored-by: Mangesh Raut <mangeshraut712@users.noreply.github.com>
Contributor
|
@mangeshraut712 thank you. Please sign the CLA (see bot instructions above), otherwise unfortunately we cannot accept the contribution |
Contributor
Author
|
CLA is signed now, EasyCLA check is green. Thanks! |
markscott-ms
approved these changes
Oct 14, 2026
markscott-ms
left a comment
markscott-ms
left a comment
Contributor
There was a problem hiding this comment.
This PR meets the requirements as specified in the issue, and appears visually okay (I built and ran the VSCode extension).
There are some further colour issues I've identified, not enumerated in the issue, but it would be unfair to criticise this PR for not addressing them. I'll either fix them or create another issue.
This was referenced Oct 14, 2026
|
Thank you @mangeshraut712 @markscott-ms: I filed the original issue. I didn't expect anyone to get to it so quickly - thanks for fixing and for looking into other colour-related issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nodes, edges, and a few panel controls in the CALM Canvas webview used fixed colours. Those colours in
calm-plugins/vscode/src/webview/canvasandpanelsnow use--vscode-*theme variables, the same waycanvas.cssalready does for the rest of the webview.canvas.cssstill has fixed colours for handles, the selection ring, and the connection line. I left that file alone.Fixes #3076
Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-server/)calm-widgets/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Ran
npm testandnpm run lintincalm-plugins/vscode. Tests passed. Lint finished with no errors (the warnings it printed were already there). I did not open the extension in VS Code.Checklist