Repository navigation
fix(vscode): use theme colours for the canvas minimap - #3358
Merged
Merged
Conversation
10 of 28 tasks
markscott-ms
force-pushed
the
fix/3076-themed-minimap
branch
from
October 14, 2026 23:20
96b298f to
1d03772
Compare
rocketstack-matt
previously approved these changes
Oct 15, 2026
markscott-ms
force-pushed
the
fix/3076-themed-minimap
branch
from
October 15, 2026 11:11
1d03772 to
6488102
Compare
rocketstack-matt
previously approved these changes
Oct 15, 2026
markscott-ms
dismissed
rocketstack-matt’s stale review
October 15, 2026 11:26
The merge-base changed after approval.
The minimap used React Flow's light-theme defaults: grey nodes, a light mask that brightened the area outside the view, and a see-through panel. It now uses theme colours. Containers show as an outline, so their children stay visible, and the selected node uses the focus colour. The border is mixed from the theme foreground, because many themes set widget.border close to the background.
rocketstack-matt
force-pushed
the
fix/3076-themed-minimap
branch
from
October 15, 2026 11:26
6488102 to
c6e3829
Compare
rocketstack-matt
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #3359: review that PR first. This PR is based on its branch, so the diff shows only the minimap change. Follow-up to #3076.
The canvas minimap used React Flow's light-theme defaults. In dark themes, the area outside the view was a bright grey haze, every node was the same bright grey, and the panel let the canvas show through.
--calm-bg-secondary--vscode-widget-border, which many themes set close to the background--vscode-contrastBorderin high-contrast themes, otherwise 70% of the theme foreground mixed into the background#e2e2e2--calm-fg-mutedat 70%--calm-focus--calm-bg-secondaryat 65%, which dims itTechnical notes:
canvas.css. CSS overrides thefillattributes that React Flow sets, so the selected state and the container class can have their own colours.vector-effect: non-scaling-stroke, so it stays 1px when the minimap scales a large diagram down.Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-server/)calm-widgets/)docs/)shared/)calm-plugins/vscode/)Commit Message Format ✅
Testing
A unit test covers the container class. The colours were checked visually in the webview, in light and dark themes.
Checklist