Skip to content

ci: generate js and definitions from ts and place in original location #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

06kellyjac
Copy link
Contributor

  • chore: dont publish experimental or cypress
  • build: generate js and definitions from ts and place in original location
  • build: add guardrails and add to publish

Copy link

netlify bot commented May 14, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 8810a63
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6824b0c4a07068000851a618

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.82%. Comparing base (f7932be) to head (8810a63).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   49.82%   49.82%           
=======================================
  Files          48       48           
  Lines        1724     1724           
  Branches      176      176           
=======================================
  Hits          859      859           
  Misses        841      841           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@06kellyjac 06kellyjac changed the title build: generate js and definitions from ts and place in original location ci: generate js and definitions from ts and place in original location May 14, 2025
@JamieSlome JamieSlome self-requested a review May 15, 2025 09:38
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit da663f3 into finos:main May 15, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants