Restore firefox support by removing captrue group from regex pattern#1048
Conversation
…roup from regex
|
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement. Having reviewed our contributor list, we require a CLA for the following people : (@telamonian). If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email help@finos.org with your questions. Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. cc @finos-admin |
|
What the heck, didn't we go through this last time? I'm already marked as a contributor @finos, @finos-admin, please see #958, #1015 |
sc1f
left a comment
There was a problem hiding this comment.
Thanks for the fix - looks great!
I accidentally left in the named group when writing the expressions editor, and never ended up using the group at all. There's a commit up on a separate unrelated PR that fixes this as well (as I discovered the issue while working on this other PR), but the change is exactly the same and we should merge yours first.
|
Thanks for the PR! |
|
Hi @telamonian, I'm sorry you experienced issues with the CLA Bot during this contribution. Please feel reassured the CLA Bot is here to keep contributions into Perspective safe and we have now whitelisted you which lets the bot know you are an approved and trusted member of the team. If you experience any further issues, please do email FINOS at help@finos.org as we're more than happy to help. James. |
|
@finos-cla-bot[bot] check |
|
The cla-bot has been summoned, and re-checked this pull request! |
fixes #1047