Skip to content

Restore firefox support by removing captrue group from regex pattern #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
texodus merged 1 commit into from
May 18, 2020
Merged

Restore firefox support by removing captrue group from regex pattern #1048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/perspective-viewer/src/js/computed_expressions/lexer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const UpperLowerCaseTokenType = createToken({
});

// Create tokens for column names and computed function names
const column_name_regex_pattern = /(["'])(?<column_name>.*?[^\\])\1/y;
const column_name_regex_pattern = /(["'])(.*?[^\\])\1/y;

/**
* Given a string from which to extract a column name, extract the column name
Expand Down