Conversation
93978c9 to
7c5bac6
Compare
f8087fa to
ea0587d
Compare
ea0587d to
e433682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new implementation of
<perspective-viewer>'s Expression Editor component, which replacesmonaco-editor. Whilemonaco-editorhas lots of enviable features, it also had some issues:monaco-editorpackages and imports it's own CSS, which causes issues when building with CSS-aware tools likewebpackand required special consideration during installation, in general making the first-impression experience poor.New Columnbutton),monaco-editorwas2.6mb, by far the largest component in the project, and parsed/loaded much slower than similarly-sized WASM assets as it is JavaScript. The non-lazy part still imparted a ~100kJS payload in the main bundle.monaco-editorare just not needed for the much smalled scope of an expression editor (e.g. "Rename Symbol" is probably not worth the code download and I doubt many users even knew it was there, hidden in the right-click or command-P menu).The new version has been implemented-from-scratch:
35kin total (including the new Rust libraries added likenom). When accounting for themonaco-editorRust FFI code removed, even the WASM asset is actually slightly smaller than in1.6.7:monaco-editorversion as the message is now displayed in the status bar, rather than in a tooltip).There are still some missing features.. Given the developer-experience impact of this change, I think its worth merging even as-is, with an eye towards addressing these shortcomings in the next few releases: