Add aarch64 Mac runners to test_python, restore PSP_ARCH dev behavior#2802
Merged
texodus merged 2 commits intoperspective-dev:masterfrom Oct 25, 2024
Merged
Add aarch64 Mac runners to test_python, restore PSP_ARCH dev behavior#2802texodus merged 2 commits intoperspective-dev:masterfrom
texodus merged 2 commits intoperspective-dev:masterfrom
Conversation
this matches the behavior pre-toolchain patch -- if PSP_ARCH is not set, then no toolchain file is defined, and the build proceeds without setting `CMAKE_OSX_ARCHITECTURES` Signed-off-by: Tom Jakubowski <tom@prospective.dev>
Contributor
Author
|
Workflow run from my fork on current HEAD of this branch (3282a8c) with a test release tag: https://github.com/tomjakubowski/perspective/actions/runs/11471445415 |
tomjakubowski
commented
Oct 23, 2024
| with: | ||
| name: perspective-python-dist-${{ matrix.arch }}-${{ matrix.os }}-${{ matrix.python-version }} | ||
| # the macos-14 runner tests artifacts built on macos-13 | ||
| name: perspective-python-dist-${{ matrix.arch }}-${{ matrix.os == 'macos-14' && 'macos-13' || matrix.os }}-${{ matrix.python-version }} |
Contributor
Author
There was a problem hiding this comment.
this shell-looking code is how ternaries are done in github actions expressions
macos-14 is aarch64 with Apple silicon. This lets us test the aarch64 wheel in CI Will try a follow up to see if the builds are any faster on macos-14. Will want to double check we still have a good value for `CMAKE_OSX_DEPLOYMENT_TARGET`/`MACOSX_DEPLOYMENT_TARGET` after upgrading the builders Signed-off-by: Tom Jakubowski <tom@prospective.dev> new crack at build matrix verified this one with a model of the behavior in github's docs. would be cool if I knew how to get github to print the job configurations before the job actually runs
tomjakubowski
force-pushed
the
macos-14-tester
branch
from
ed9c823 to
89964b6
Compare
Contributor
Author
|
OK, I think I've fixed the issue where bogus test_python job configurations were being created. Open for review |
texodus
approved these changes
Oct 25, 2024
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up #2798. We weren't previously testing the aarch64 wheel in CI. This adds a macos-14 runner, which is aarch64 native.
I also restored the previous dev environment behavior when PSP_ARCH is not set: instead of a fatal build error, the build just doesn't set
CMAKE_OSX_ARCHITECTURES(et al).Pull Request Checklist