Update column paths when the column set changes in perspective-viewer-datagrid
#3047
+451
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-datagrid` Signed-off-by: Andrew Stein <[email protected]>
texodus
force-pushed
the
fix-datagrid-columns
branch
from
1d97710 to
cdf15a7
Compare
Signed-off-by: Andrew Stein <[email protected]>
texodus
force-pushed
the
fix-datagrid-columns
branch
from
cdf15a7 to
8a8556e
Compare
texodus
changed the title
perspective-viewer-datagridperspective-viewer-datagrid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
perspective-viewer-datagridto handlesplit_bycolumns which change due to aTable::updatecall which introduces a new value (or removes all instances of an existing one).In order to implement this fix without requiring the datagrid to fetch all column names for each tick, two breaking API changes are introduced as well:
View::column_pathsnow takes optionalColumnWindowstart_colandend_colbounds.View::column_pathsnow no longer returns__ROW_PATH__as an output column when agroup_byis applied (though this column is still in the output data).Screen.Recording.2025-08-23.at.9.11.39.PM.mov