Merged
Conversation
Member
|
Thanks for the PR! This is a great addition - User experience is awesome, and the tests in particular are greatly appreciated! I think as a future enhancement we may want to reconsider this API, in favor of general validation across APIs which take configuration objects as parameters - see also my comments on API differences between viewer and library. I think this will help keep the API surface small, predictable, as well as portable and consistent between host languages. As this is currently undocumented, IMO it is fine as is for now. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#349 UI filters should give user feedback when they are valid