Skip to content

Empty filters#387

Merged
texodus merged 2 commits intoperspective-dev:masterfrom
Ro4052:empty-filters
Jan 29, 2019
Merged

Empty filters#387
texodus merged 2 commits intoperspective-dev:masterfrom
Ro4052:empty-filters

Conversation

@Ro4052
Copy link
Contributor

@Ro4052 Ro4052 commented Jan 18, 2019

#349 #375 Prior to my pull request for invalid filters, I've had a slight re-think of my implementation. My implementation resulted in empty strings being invalid filter operands. Although this makes sense for the viewer component, it doesn't seem to be appropriate for those using Perspective without the viewer. Therefore, I've pulled the check for empty strings into the viewer and updated the tests as necessary.

@timkpaine timkpaine added the JS label Jan 22, 2019
@texodus
Copy link
Member

texodus commented Jan 29, 2019

Thanks for the PR!

While this is most certainly more correct, the issue is a bit complex - users should be able to do anything that developers can do wrt data transforms, eg filter on datasets with empty string values - and null values for that matter, which perspective uses for both invalid aggregates as well as missing values. Like I said in the previous PR, I think this functionality ultimately needs a bit of a re-think, both in terms of its API and user experience - in the interim, any imporvement is warranted!

@texodus texodus merged commit 8494027 into perspective-dev:master Jan 29, 2019
@Ro4052 Ro4052 deleted the empty-filters branch January 29, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants