Skip to content

Fix handling of model_dir in launch.py #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
+6 −3
Merged

Fix handling of model_dir in launch.py #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tracdap-runtime/python/src/tracdap/rt/launch/launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def _resolve_config_file(
return parent_config_path

if model_dir is not None:
model_config_path = _search_parent_paths(cwd, config_path)
model_config_path = _search_parent_paths(model_dir, config_path)
if model_config_path is not None:
return model_config_path

Expand Down Expand Up @@ -132,8 +132,11 @@ def launch_model(
# Default to dev_mode = True for launch_model()
dev_mode = launch_args["dev_mode"] if "dev_mode" in launch_args else True

model_file = _inspect.getfile(model_class)
model_dir = _pathlib.Path(model_file).parent
try:
model_file = _inspect.getfile(model_class)
model_dir = _pathlib.Path(model_file).parent
except OSError:
model_dir = None

_sys_config = _resolve_config_file(sys_config, model_dir, dev_mode)
_job_config = _resolve_config_file(job_config, model_dir, dev_mode)
Expand Down
Loading