-
Notifications
You must be signed in to change notification settings - Fork 34
#1643 Add support for EpochTimestamp and Decimal #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
stonesmi
wants to merge
24
commits into
finos:main
Choose a base branch
from
stonesmi:#1643-EpochTimeStampMillis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
… into finos#1643-EpochTimeStampMillis # Conflicts: # vuu/src/test/scala/org/finos/vuu/core/table/ColumnTest.scala # vuu/src/test/scala/org/finos/vuu/net/json/RowUpdateSerializerTest.scala
… into finos#1643-EpochTimeStampMillis
…EpochTimeStamp # Conflicts: # vuu/src/main/scala/org/finos/vuu/core/sort/SortCompares.scala # vuu/src/test/scala/org/finos/vuu/core/sort/GenericSortTest.scala # vuu/src/test/scala/org/finos/vuu/core/sort/SortComparesTest.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for two new column types in the Vuu backend. Further work will be required on the Front-end to support these.
1) EpochTimestamp
This is a wrapper around a Long, containing the number of Nanoseconds since Unix epoch. It uses less memory than java.time.Instant.
2) Decimal
This is a wrapper around a Long, containing a Decimal value that has been multiplied by 10^8 to move the decimal point. Any precision beyond 8 decimal places is lost.
It also only supports Decimal values between -92,233,720,368.54775808 and 92,233,720,368.54775807
3) Misc
I also fixed a few issues that were spotted in the code as I added these features: