Skip to content

Conversation

@firasdarwish
Copy link
Owner

No description provided.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (50afc6b) to head (c492a9f).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
key.go 20.00% 4 Missing ⚠️
container_keyed_registerers.go 33.33% 2 Missing ⚠️
lifetimes.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   85.20%   88.95%   +3.74%     
==========================================
  Files          19       19              
  Lines         561      534      -27     
==========================================
- Hits          478      475       -3     
+ Misses         71       42      -29     
- Partials       12       17       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@firasdarwish firasdarwish merged commit 91d373a into main Nov 15, 2024
4 of 6 checks passed
@firasdarwish firasdarwish deleted the r/0.6.1 branch November 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants