Add validation feature, Add benchmark #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle circular DI: panic with a nice error instead of call stack overflow - detect lifetime misalignment to panic - add ore.validate() func to panic early if the container is bad configured
duongphuhiep
force-pushed
the
main
branch
2 times, most recently
from
d0252cd to
fe0444e
Compare
Collaborator
Author
|
hmm, on my machine, all test is green, I'm unable to make the test failed as in the pipeline, not sure where is the problem :-( |
Collaborator
Author
|
fixed, time.Now() on Windows and on Linux is sligtly different |
|
Owner
|
thank you for your invaluable contributions @duongphuhiep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect circular dependency: panic with a human readable message instead of Big unreadable stack overflow (can give more info on the circular deps in the future)
Panic on Lifetime misalignment (when a longer lifetime depends on a Shorter lifetime)
Add
ore.Validate()invokes ALL your registered resolvers, it panics when something gone wrong. The purpose of this function is to panic early (on the test pipeline or application startup) when the Container is bad configured:Add benchmark to compare with Samber/Do