Skip to content

Commit 152f694

Browse files
authored
Fix Github tests (#1426)
2 parents 98353a7 + 35d8a2f commit 152f694

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

auth/src/test/java/com/firebase/ui/auth/viewmodel/SocialProviderResponseHandlerTest.java

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import java.util.ArrayList;
4545
import java.util.Arrays;
4646
import java.util.Collections;
47-
import java.util.List;
4847

4948
import static com.google.common.truth.Truth.assertThat;
5049
import static org.mockito.ArgumentMatchers.any;
@@ -64,16 +63,19 @@ public class SocialProviderResponseHandlerTest {
6463

6564
private SocialProviderResponseHandler mHandler;
6665

66+
private static final ArrayList<String> NON_GITHUB_PROVIDERS = new ArrayList<>();
67+
static {
68+
NON_GITHUB_PROVIDERS.addAll(AuthUI.SUPPORTED_PROVIDERS);
69+
NON_GITHUB_PROVIDERS.remove(GithubAuthProvider.PROVIDER_ID);
70+
}
71+
6772
@Before
6873
public void setUp() {
6974
TestHelper.initialize();
7075
MockitoAnnotations.initMocks(this);
7176

7277
mHandler = new SocialProviderResponseHandler(RuntimeEnvironment.application);
73-
74-
List<String> allExceptGitHub = new ArrayList<>(AuthUI.SUPPORTED_PROVIDERS);
75-
allExceptGitHub.remove(GithubAuthProvider.PROVIDER_ID);
76-
FlowParameters testParams = TestHelper.getFlowParameters(allExceptGitHub);
78+
FlowParameters testParams = TestHelper.getFlowParameters(NON_GITHUB_PROVIDERS);
7779

7880
mHandler.initializeForTesting(testParams, mMockAuth, null, null);
7981
}
@@ -316,7 +318,8 @@ public void testSignInIdp_anonymousUserUpgradeEnabledAndExistingPasswordUserWith
316318

317319
private void setupAnonymousUpgrade() {
318320
// enableAnonymousUpgrade must be set to true
319-
FlowParameters testParams = TestHelper.getFlowParameters(AuthUI.SUPPORTED_PROVIDERS, /* enableAnonymousUpgrade */ true);
321+
FlowParameters testParams = TestHelper.getFlowParameters(NON_GITHUB_PROVIDERS,
322+
/* enableAnonymousUpgrade */ true);
320323
mHandler.initializeForTesting(testParams, mMockAuth, null, null);
321324

322325
when(mUser.isAnonymous()).thenReturn(true);

0 commit comments

Comments
 (0)