Skip to content

Fix Github tests #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Fix Github tests #1426

merged 2 commits into from
Aug 29, 2018

Conversation

samtstern
Copy link
Contributor

This fixes #1425

We can't add a dependency from auth to auth-github because that would be circular.

Maybe we need an auth-common module in the long term? That would be a bit unfortunate, but could fix the issue.

Change-Id: Ic2cd64fb53cd5b932c8b2920d2bfb084e70cc48e
@samtstern samtstern requested a review from SUPERCILEX August 29, 2018 16:06
@samtstern samtstern added this to the 4.2.0 milestone Aug 29, 2018
*/
public static final Set<String> SUPPORTED_PROVIDERS =
Collections.unmodifiableSet(new HashSet<>(Arrays.asList(
GoogleAuthProvider.PROVIDER_ID,
FacebookAuthProvider.PROVIDER_ID,
TwitterAuthProvider.PROVIDER_ID,
GithubAuthProvider.PROVIDER_ID,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, that's a public API, not part of TestConstants. 😛 I wasn't merged up with master before so I didn't see the changes. Here's how I fixed it:

List<String> allExceptGitHub = new ArrayList<>(AuthUI.SUPPORTED_PROVIDERS);
allExceptGitHub.remove(GithubAuthProvider.PROVIDER_ID);
FlowParameters testParams = TestHelper.getFlowParameters(allExceptGitHub);

If we did that here:

FlowParameters testParams = TestHelper.getFlowParameters(AuthUI.SUPPORTED_PROVIDERS, /* enableAnonymousUpgrade */ true);
mHandler.initializeForTesting(testParams, mMockAuth, null, null);

it should work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah, I couldn't find a way to include GitHub in the tests. 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh holy crap haha I did not look at my file path!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No prob 😆

Change-Id: I5e8824935940c9e1a876fea7da0969b97755730e
@samtstern samtstern merged commit 152f694 into version-4.2.0-dev Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants