-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implement "Phase 1" of anonymous user upgrade #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you have a high level estimate on when this "Phase 1" will be released? I know we can always follow the SUPERCILEX approach but if we get it in a reasonable timeframe from the original source it might worth the wait. |
@atrepeklis sorry I don't have a good estimate right now. |
@SUPERCILEX I am going to take a crack at this, using #309 as my guide. |
@samtstern Awesome! I'm going to crunch through my backlog tomorrow. 😊 |
@samtstern Do you have an active branch for this? Your approach above sounds simple and I was considering forking the repo to do this in my own app. I figured I would check for a branch here that may need a nudge to get it over the hump and approved instead of creating the fork. |
See #1358 |
This has been released in version |
Should this not be . |
This is related to #309 but because of the huge traffic / discussion over there I want to file a new clean issue about this piece.
For context this has already been release on Web and is coming in iOS:
https://github.com/firebase/firebaseui-web#upgrading-anonymous-users
This has two parts:
1 - New Flow Parameter
There will be a new boolean option to the intent builder, with the default as false:
Throughout the flow, wherever we previously called
signInWith...
orsignUpWith...
we will now do the following logic (pseudocode):2 - Handling Link Failures
In the event that a link call fails, we will exit the flow with an error:
When handling the error, the developer should:
Notes
In a future "phase" of this feature we can do something similar to what @SUPERCILEX has already done and handle the complete flow including data transfer. In this "minimal" phase though this will only be for advanced developers that can handle the data transfer and display any relevant UI during that operation.
The text was updated successfully, but these errors were encountered: