Upgrading anonymous accounts #1358

lsirac · 2018-06-14T19:07:01Z

For implementation details, see #1171.

samtstern

Looking pretty good so far! Some drive-by comments.

samtstern · 2018-06-14T20:01:24Z

app/src/main/java/com/firebase/uidemo/auth/AuthUiActivity.java

-                                mEnableHintSelector.isChecked())
-                        .build(),
-                RC_SIGN_IN);
+        FirebaseAuth.getInstance()


If you look at my (now-closed) PR I added a whole separate sample Activity for anonymous. You might as well copy it, IMO it shows off the flow nicely without complicating the "normal" one.

samtstern · 2018-06-14T20:04:12Z

auth/src/main/java/com/firebase/ui/auth/data/remote/EmailSignInHandler.java

@@ -29,7 +30,7 @@ public void startSignIn(@NonNull HelperActivityBase activity) {

    @Override
    public void onActivityResult(int requestCode, int resultCode, @Nullable Intent data) {
-        if (requestCode == RequestCodes.EMAIL_FLOW) {
+        if (requestCode == RequestCodes.EMAIL_FLOW && resultCode != ErrorCodes.ANONYMOUS_UPGRADE_MERGE_CONFLICT) {


nit: this may be a little clearer if you add a separate block at the top:

if (resultCode == ErrorCodes.ANONYMOUS_UPGRADE_MERGE_CONFLICT) { // Add comment explaining why return; }

samtstern · 2018-06-14T20:05:04Z

auth/src/main/java/com/firebase/ui/auth/data/remote/SignInKickstarter.java

@@ -182,7 +184,13 @@ public void onActivityResult(int requestCode, int resultCode, @Nullable Intent d
                } else if (response.isSuccessful()) {
                    setResult(Resource.forSuccess(response));
                } else {
-                    setResult(Resource.<IdpResponse>forFailure(response.getError()));
+                    if (response.getError().getErrorCode() ==


nit: rather than:

else { if { } else { } }

Should just be another else if followed by a final else

samtstern · 2018-06-14T20:06:48Z

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

@@ -98,6 +111,9 @@ protected void onFailure(@NonNull Exception e) {
                            R.integer.fui_min_password_length));
                } else if (e instanceof FirebaseAuthInvalidCredentialsException) {
                    mEmailInput.setError(getString(R.string.fui_invalid_email_address));
+                } else if (e instanceof FirebaseAuthAnonymousUpgradeException) {
+                    IdpResponse response = ((FirebaseAuthAnonymousUpgradeException) e).getResponse();
+                    ((AnonymousUpgradeListener) getActivity()).onMergeFailure(response);


This is fine, however you could optionally assert the cast in onActivityCreated and then store a listener reference rather than casting here.

samtstern · 2018-06-14T20:07:51Z

auth/src/main/java/com/firebase/ui/auth/util/data/AnonymousUpgradeUtils.java

+@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
+public class AnonymousUpgradeUtils {
+
+    public static Task<AuthResult> createUserWithEmailAndPasswordOrLink(@NonNull FirebaseAuth auth,


naming nit: createOrLinkUserWith... reads better to me.

samtstern · 2018-06-14T20:08:37Z

auth/src/main/java/com/firebase/ui/auth/util/data/AnonymousUpgradeUtils.java

+        // Create a new FirebaseApp so that the anonymous user state is not lost in our
+        // original FirebaseAuth instance.
+        String randomName = UUID.randomUUID().toString();
+        FirebaseApp scratchApp = FirebaseApp.initializeApp(


I think initializeApp is expensive enough that we'd want to cache a singleton "other app" to use for all scratch operations.

samtstern · 2018-06-14T20:09:47Z

auth/src/main/java/com/firebase/ui/auth/viewmodel/email/EmailProviderResponseHandler.java

-                                            setResult(Resource.<IdpResponse>forFailure(e));
-                                        }
-                                    });
+                            if (AnonymousUpgradeUtils.canUpgradeAnonymous(getAuth(),


Maybe instead of overloading this branch we should have the createOrLink method transform collision errors into a custom error class with a Continuation?

samtstern · 2018-06-14T20:11:19Z

auth/src/main/java/com/firebase/ui/auth/viewmodel/email/WelcomeBackPasswordHandler.java

-                                    .continueWithTask(new ProfileMerger(outputResponse))
-                                    .addOnFailureListener(new TaskFailureLogger(TAG, "linkWithCredential+merge failed."));
+            AnonymousUpgradeUtils.validateCredential(FirebaseApp.getInstance(), credToValidate)
+                    .continueWith(new Continuation<AuthResult, Void>() {


Seems like there's no need for a Continuation here since the chain ends. Maybe it should be an OnCompleteListener?

…WelcomeBackIdpPrompt).

samtstern

Looking good! Mostly small style/clarity comments.

By the way: if you want we can do this in multiple PRs. Like perfect what you've done so far and finish it in a second PR. That way the size of the PR stays sane and we can discuss a subset of the issues.

samtstern · 2018-06-15T17:47:32Z

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

@@ -1107,10 +1107,23 @@ public Intent build() {
     * Builder for the intent to start the user authentication flow.
     */
    public final class SignInIntentBuilder extends AuthIntentBuilder<SignInIntentBuilder> {
+
+        private boolean mEnableAnonymousUpgrade;


Any reason why this boolean is part of SignInIntentBuilder and not AuthIntentBuilder?

The doc says to add it in SignInIntentBuilder. You also added it here in your PR.

samtstern · 2018-06-15T17:49:06Z

auth/src/main/java/com/firebase/ui/auth/IdpResponse.java

-                        "Token cannot be null when using a non-email provider.");
+            if (mPendingCredential != null) {
+                return new IdpResponse(mPendingCredential, new FirebaseUiException(ErrorCodes.ANONYMOUS_UPGRADE_MERGE_CONFLICT));
+            } else {


Since the if returns, no need for this else. We can remove a level of nesting here.

samtstern · 2018-06-15T17:55:50Z

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

@@ -198,6 +216,9 @@ public void run() {
    public void onActivityCreated(@Nullable Bundle savedInstanceState) {
        super.onActivityCreated(savedInstanceState);
        requireActivity().setTitle(R.string.fui_title_register_email);
+        FragmentActivity activity = getActivity();


tiny nit: any reason we need can't just cast getActivity() directly?

I'm going to keep it like this and add a check that it implements AnonymousUpgradeListener and throw an exception if it doesn't.

samtstern · 2018-06-15T17:56:26Z

auth/src/main/java/com/firebase/ui/auth/ui/email/WelcomeBackPasswordPrompt.java

            }
        });

        TextView footerText = findViewById(R.id.email_footer_tos_and_pp_text);
        PrivacyDisclosureUtils.setupTermsOfServiceFooter(this, getFlowParams(), footerText);
    }

+    public void onMergeFailure(IdpResponse response) {


Could this be moved into the base activity? Seems like it's pretty much the same everywhere?

samtstern · 2018-06-15T17:57:29Z

auth/src/main/java/com/firebase/ui/auth/ui/phone/PhoneActivity.java

+                    IdpResponse response = ((FirebaseAuthAnonymousUpgradeException) e).getResponse();
+                    onMergeFailure(response);
+                } else {
+                    handleError(e);


Should the if/else block be moved into handleError? Seems weird to have a handle method that doesn't do all cases.

samtstern · 2018-06-15T18:03:13Z

auth/src/main/java/com/firebase/ui/auth/viewmodel/SignInViewModelBase.java

+    protected void handleMergeFailure(@NonNull AuthCredential credential) {
+        IdpResponse failureResponse = new IdpResponse.Builder(credential)
+                .build();
+        setResult(Resource.<IdpResponse>forFailure(new FirebaseAuthAnonymousUpgradeException(


You could also make FirebaseAuthAnonymousUpgradeException have a constructor that takes AuthCredential since you're just converting the credential to an IdpResponse

If not, this method should call the method below since they are the same setResult call

samtstern · 2018-06-15T18:05:53Z

auth/src/main/java/com/firebase/ui/auth/viewmodel/email/WelcomeBackPasswordHandler.java

+                        }
+                    });
+
+        } else {


Same nit as before.

When a method is just

if (condition) { action1; } else { action2; }

Consider:

if (condition) { action1; return; } action2

With something like you have here it helps from getting into crazy indentation levels.

samtstern · 2018-06-15T18:06:33Z

auth/src/main/java/com/firebase/ui/auth/viewmodel/email/WelcomeBackPasswordHandler.java

-                            setResult(Resource.<IdpResponse>forFailure(task.getException()));
-                            return;
+                    })
+                    .addOnCompleteListener(new OnCompleteListener<AuthResult>() {


nit: fine either way but when your onCompleteListener just has a succcess-or-not branch you may find it clearer to use separate onSuccess and onFailure listeners.

samtstern · 2018-06-15T18:09:24Z

auth/src/main/java/com/firebase/ui/auth/viewmodel/idp/LinkingSocialProviderResponseHandler.java

+                                    FirebaseAuthUserCollisionException){
+                                handleMergeFailure(credential);
+                            }
+                            // I'm not sure why we ignore other failures here, but this mirrors


This comment is no longer relevant?

Well we still ignore other failures though. We only deal w/ a merge failure. I'll remove it.

samtstern · 2018-06-15T18:12:15Z

auth/src/main/java/com/firebase/ui/auth/viewmodel/phone/PhoneProviderResponseHandler.java

+                        handleSuccess(response, result);
+                    }
+                })
+                .addOnFailureListener(new OnFailureListener() {


optional: if you look at my PR you'll notice I made a type of Task that uses the type system to force you to handle merge exceptions at all call sites. Since you are pretty constantly doing instanceof checks on the exceptions for these operations you may want to consider something like that.

I'll come back to this.

samtstern · 2018-06-15T18:13:50Z

@lsirac just a warning, Github is stupid and collapses reviews sometimes. So look out for stuff like this:

SUPERCILEX · 2018-06-15T18:34:11Z

Will take a look later today.

SUPERCILEX · 2018-06-18T07:29:22Z

app/src/main/java/com/firebase/uidemo/auth/AuthUiActivity.java

@@ -41,6 +41,7 @@
 import com.google.android.gms.common.Scopes;
 import com.google.android.gms.tasks.OnCompleteListener;
 import com.google.android.gms.tasks.Task;
+import com.google.firebase.auth.AuthCredential;


Erroneous import

SUPERCILEX · 2018-06-18T07:30:13Z

auth/src/main/java/com/firebase/ui/auth/AuthUI.java

+         * flow. This is disabled by default.
+         */
+        @NonNull
+        public SignInIntentBuilder setAutoUpgradeAnonymousUsers() {


This should take in a boolean autoUpgrade parameter.

Sure but when would they ever call this with false? It's disabled by default.

Oh, gotya. Then the javadoc needs to be updated to just Enables upgrading ... and the method needs to be renamed to something like enableAutoUpgradeAnonymousUsers.

Yeah I'm going to ask if I can change the API actually. It'll probably have to take in a boolean to be the same as iOS/Web

@lsirac you can definitely change the API to take a boolean without asking anyone.

SUPERCILEX · 2018-06-18T07:31:46Z

auth/src/main/java/com/firebase/ui/auth/ErrorCodes.java

@@ -67,6 +73,8 @@ public static String toFriendlyMessage(@Code int code) {
                return "Developer error";
            case PROVIDER_ERROR:
                return "Provider error";
+            case ANONYMOUS_UPGRADE_MERGE_CONFLICT:
+                return "Merge conflict";


This should be a slightly more user friendly message like User account conflict

SUPERCILEX · 2018-06-18T07:34:50Z

auth/src/main/java/com/firebase/ui/auth/FirebaseAuthAnonymousUpgradeException.java

+    public FirebaseAuthAnonymousUpgradeException(@ErrorCodes.Code int code,
+                                                 @NonNull IdpResponse response) {
+        super(ErrorCodes.toFriendlyMessage(code));
+        this.response = response;


Nit: no this, use mResponse. We'll finally be able to get rid of that convention when we start using Kotlin, but for now, we should be consistent.

SUPERCILEX · 2018-06-18T07:37:01Z

auth/src/main/java/com/firebase/ui/auth/IdpResponse.java

@@ -218,7 +232,6 @@ public void writeToParcel(Parcel dest, int flags) {
        dest.writeString(mToken);
        dest.writeString(mSecret);
        dest.writeInt(mIsNewUser ? 1 : 0);
-


Nit: leave the space here since this is an unpleasant, unconventional write below.

SUPERCILEX · 2018-06-18T07:41:53Z

auth/src/main/java/com/firebase/ui/auth/data/model/Resource.java

@@ -65,6 +65,10 @@ public T getValue() {
        return mValue;
    }

+    public boolean hasValue() {
+        return mValue != null;
+    }


Please remove this. It's not used anywhere and you should be checking the states instead.

Oops, done.

SUPERCILEX · 2018-06-18T07:45:24Z

auth/src/main/java/com/firebase/ui/auth/ui/HelperActivityBase.java

@@ -42,6 +43,10 @@ protected void onActivityResult(int requestCode, int resultCode, Intent data) {
        if (requestCode == RequestCodes.CRED_SAVE_FLOW) {
            finish(resultCode, data);
        }
+
+        if (resultCode == ErrorCodes.ANONYMOUS_UPGRADE_MERGE_CONFLICT) {


Nit: merge this with the if above.

SUPERCILEX · 2018-06-18T07:46:20Z

auth/src/main/java/com/firebase/ui/auth/ui/HelperActivityBase.java

@@ -70,4 +75,8 @@ public void startSaveCredentials(
                this, getFlowParams(), credential, response);
        startActivityForResult(intent, RequestCodes.CRED_SAVE_FLOW);
    }
+
+    public void onMergeFailure(IdpResponse response) {
+        finish(ErrorCodes.ANONYMOUS_UPGRADE_MERGE_CONFLICT, response.toIntent());


I'd prefer we not do this. We have this inlined in all the other call sites so we don't end up with a God activity.

What do you suggest we do?

Oh, sorry for not being clearer, I was just saying to inline this like we do elsewhere. This would be easiest: https://www.jetbrains.com/help/idea/inline.html

SUPERCILEX · 2018-06-18T07:48:04Z

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java

@@ -198,6 +216,12 @@ public void run() {
    public void onActivityCreated(@Nullable Bundle savedInstanceState) {
        super.onActivityCreated(savedInstanceState);
        requireActivity().setTitle(R.string.fui_title_register_email);
+        FragmentActivity activity = getActivity();


Nit: merge with requireActivity from above

SUPERCILEX · 2018-06-18T07:55:16Z

auth/src/main/java/com/firebase/ui/auth/IdpResponse.java

@@ -207,6 +216,11 @@ public FirebaseUiException getError() {
        return mException;
    }

+    @Nullable
+    public AuthCredential getCredentialForLinking() {
+        return mPendingCredential;


Is it still going to be valid after we use it?

SUPERCILEX · 2018-06-18T08:06:26Z

@samtstern and there's really no way we can just go all the way with something like #309? The whole "fail sign-in on conflict and just let the dev deal with it" is kinda wishful thinking. 😊

samtstern · 2018-06-18T18:30:11Z

@SUPERCILEX yeah I know ... at least for phase 1 I have been overruled. But I think we can make phase 2 look a lot like #309 ...

SUPERCILEX · 2018-06-18T18:33:08Z

Alrighty, then yeah, the design LGTM 👍

samtstern · 2018-06-19T20:07:51Z

@lsirac do you have anything else you want to do here?

SUPERCILEX · 2018-06-19T20:13:06Z

I think there's a commit waiting to be pushed? Or at least, @lsirac responded to all my comments. 🤷‍♂️ (Thanks BTW ❤️)

lsirac · 2018-06-19T20:48:33Z

@samtstern There's a commit otw for changes based on Alex's feedback and federated sign-in using existing email (email belongs to federated account) w/ no mismatch cases (email belongs to federated acc and email belongs to password account)

…mail mismatch and added code review changes.

samtstern · 2018-06-21T22:53:42Z

@lsirac Travis is unhappy:

  Line 45:     testImplementation(Config.Libs.Test.truth)
                                                   ^ Unresolved reference: truth

samtstern · 2018-06-21T22:55:13Z

auth/src/main/java/com/firebase/ui/auth/util/data/AuthOperationManager.java

+    private static AuthOperationManager mAuthManager;
+
+    @VisibleForTesting
+    public FirebaseAuth mScratchAuth;


@SUPERCILEX fwiw I authorized this kind of test hackery since @lsirac was stuck on other ways to inject this auth. So if you have complaints direct them at me but if you have suggestions they are welcome!

Haha, SGTM. I'll see if I can come up with something later, but for now, whatever works. 👍

lsirac · 2018-06-21T23:16:11Z

enableAnonymousUsersAutoUpgrade or enableAutoUpgradeAnonymousUsers?

SUPERCILEX · 2018-06-21T23:43:39Z

auth/build.gradle.kts

@@ -1,3 +1,6 @@
+
+import Config.Libs.Lint.api
+import Config.Plugins.android


Mmmm, I'd just get rid of these from GitHub. Looks like AS keeps adding them back for some reason.

Let's not worry about it, I'd rather not fight AS esp when this isn't code we ship to developers.

SUPERCILEX · 2018-06-21T23:44:04Z

And I'd say enableAutoUpgradeAnonymousUsers sounds nice

SUPERCILEX · 2018-06-21T23:44:30Z

Actually, how about enableAutoAnonymousUserUpgrades?

samtstern · 2018-06-22T16:09:12Z

@lsirac I downloaded the PR and tried to run the sample app without the proper config and this happened:

2018-06-22 09:07:49.064 7906-7906/com.firebase.uidemo E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.firebase.uidemo, PID: 7906
    java.lang.IllegalStateException: Facebook provider unconfigured. Make sure to add a `facebook_application_id` string. See the docs for more info: https://github.com/firebase/FirebaseUI-Android/blob/master/auth/README.md#facebook
        at com.firebase.ui.auth.util.Preconditions.checkConfigured(Preconditions.java:90)
        at com.firebase.ui.auth.AuthUI$IdpConfig$FacebookBuilder.<init>(AuthUI.java:917)
        at com.firebase.uidemo.auth.AnonymousUpgradeActivity.startAuthUI(AnonymousUpgradeActivity.java:84)
        at com.firebase.uidemo.auth.AnonymousUpgradeActivity_ViewBinding$2.doClick(AnonymousUpgradeActivity_ViewBinding.java:53)
        at butterknife.internal.DebouncingOnClickListener.onClick(DebouncingOnClickListener.java:22)
        at android.view.View.performClick(View.java:6294)
        at android.view.View$PerformClick.run(View.java:24770)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

I assume we're enabling all social providers by default in the anonymous sample? We probably need to detect which ones are actually configured.

samtstern · 2018-06-22T16:43:08Z

@lsirac I just tested (manually) the following cases and they all worked great!

Anon --> Google (existing account)
Anon --> Email --> Welcome back Google flow
Anon --> Email (existing account)
Anon --> Email (new account)
Anon --> Phone (existing account)
Anon --> Phone (new account)
Anon --> Facebook ---> Welcome back Twitter flow

I did run into one strange issue, with my testing account [email protected] (I have both Twitter and FB set up).

Anon --> Facebook pointed me to the "Welcome back Twitter" flow
Anon --> Twitter pointed me to the "Welcome back Facebook" flow and then eventually to "unknown error"

samtstern · 2018-06-22T16:43:28Z

Oh and I was able to make the sample app crash after my "unknown error" by pressing back at the NASCAR screen:

2018-06-22 09:41:38.117 12867-12867/com.firebase.uidemo E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.firebase.uidemo, PID: 12867
    java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=123, result=0, data=null} to activity {com.firebase.uidemo/com.firebase.uidemo.auth.AnonymousUpgradeActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'com.firebase.ui.auth.FirebaseUiException com.firebase.ui.auth.IdpResponse.getError()' on a null object reference
        at android.app.ActivityThread.deliverResults(ActivityThread.java:4268)
        at android.app.ActivityThread.handleSendResult(ActivityThread.java:4312)
        at android.app.ActivityThread.-wrap19(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1644)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)
     Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'com.firebase.ui.auth.FirebaseUiException com.firebase.ui.auth.IdpResponse.getError()' on a null object reference
        at com.firebase.uidemo.auth.AnonymousUpgradeActivity.onActivityResult(AnonymousUpgradeActivity.java:143)
        at android.app.Activity.dispatchActivityResult(Activity.java:7276)
        at android.app.ActivityThread.deliverResults(ActivityThread.java:4264)
        at android.app.ActivityThread.handleSendResult(ActivityThread.java:4312) 
        at android.app.ActivityThread.-wrap19(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1644) 
        at android.os.Handler.dispatchMessage(Handler.java:106) 
        at android.os.Looper.loop(Looper.java:164) 
        at android.app.ActivityThread.main(ActivityThread.java:6494) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

lsirac · 2018-06-22T19:08:35Z

@samtstern thanks for catching that! I fixed it and changed a unit test to catch that case. 😄

samtstern

Approved after merge conflicts.

lsirac requested a review from samtstern as a code owner June 14, 2018 19:07

Adds anonymous user upgrade to Email/Password sign in

150b518

lsirac force-pushed the anonymous-user-upgrade branch from 6ddb64f to 150b518 Compare June 14, 2018 19:44

samtstern reviewed Jun 14, 2018

View reviewed changes

samtstern added this to the 4.1.0 milestone Jun 14, 2018

bobby0809 approved these changes Jun 14, 2018

View reviewed changes

lsirac added 2 commits June 14, 2018 15:20

Changes based on review

2037e85

Removes FirebaseAppManager

de66606

samtstern mentioned this pull request Jun 15, 2018

Implement "Phase 1" of anonymous user upgrade #1171

Closed

Adds anonymous user upgrade to phone auth. Also fixed email upgrade (…

db825f3

…WelcomeBackIdpPrompt).

samtstern reviewed Jun 15, 2018

View reviewed changes

Changes based on code review

be0d864

SUPERCILEX reviewed Jun 18, 2018

View reviewed changes

SUPERCILEX mentioned this pull request Jun 19, 2018

Add support for GitHub IDP #1199

Merged

lsirac added 5 commits June 19, 2018 16:30

Added linking for federated sign in with existing email. Dealt with e…

268b80a

…mail mismatch and added code review changes.

Inlines onMergeFailure

71c93da

Small fix

eee18ce

EmailActivity needs to implement onMergeFailure()

2acd64c

Adds unit tests for handlers

9d8fbbf

lsirac changed the title ~~[WIP] Upgrading anonymous accounts~~ Upgrading anonymous accounts Jun 21, 2018

samtstern reviewed Jun 21, 2018

View reviewed changes

lsirac added 3 commits June 21, 2018 16:00

Makes travis happy

30436b8

Removes erroneous imports

736eb9e

Updates javadoc

d6e0705

SUPERCILEX reviewed Jun 21, 2018

View reviewed changes

Small fix

24f9c25

SUPERCILEX approved these changes Jun 21, 2018

View reviewed changes

Adds documentation

e7ee453

samtstern mentioned this pull request Jun 22, 2018

Buttons float to top when no logo specified #1364

Closed

lsirac added 2 commits June 22, 2018 10:13

Adds provider detection in AnonymousUpgradeActivity

ab1b0ee

Fixes bugs found by Sam

5271c39

samtstern reviewed Jun 22, 2018

View reviewed changes

samtstern approved these changes Jun 22, 2018

View reviewed changes

Fix merge conflict

92bfc67

lsirac merged commit 27a2dad into version-4.1.0-dev Jun 22, 2018

samtstern mentioned this pull request Jun 22, 2018

Upgrading anonymous accounts #1368

Merged

		@@ -1,3 +1,6 @@

		import Config.Libs.Lint.api
		import Config.Plugins.android

Upgrading anonymous accounts #1358

Upgrading anonymous accounts #1358

Conversation

lsirac commented Jun 14, 2018 • edited Loading

samtstern left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samtstern commented Jun 15, 2018

SUPERCILEX commented Jun 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SUPERCILEX commented Jun 18, 2018

samtstern commented Jun 18, 2018

SUPERCILEX commented Jun 18, 2018

samtstern commented Jun 19, 2018

SUPERCILEX commented Jun 19, 2018

lsirac commented Jun 19, 2018 • edited Loading

samtstern commented Jun 21, 2018

Choose a reason for hiding this comment

lsirac commented Jun 14, 2018 •

edited

Loading

lsirac commented Jun 19, 2018 •

edited

Loading