Skip to content

Buttons float to top when no logo specified #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samtstern opened this issue Jun 22, 2018 · 3 comments
Closed

Buttons float to top when no logo specified #1364

samtstern opened this issue Jun 22, 2018 · 3 comments
Milestone
4.1.0

Comments

@samtstern
Copy link
Contributor

Easiest to see in this screenshot:
image

I am testing #1358 and saw this. So two changes:

  1. The anonymous upgrade sample should show the same logo as the regular sample.
  2. We should probably center the buttons in this case, or even just float them to the bottom.
@samtstern samtstern added this to the 4.1.0 milestone Jun 22, 2018
@SUPERCILEX
Copy link
Collaborator

SUPERCILEX commented Jun 22, 2018 •
edited
Loading

I fixed that in #1354, so y'all probably just haven't merged yet?

@samtstern
Copy link
Contributor Author

@SUPERCILEX yep you're right, when running from 4.1.0-dev it's all good. Thanks!

@SUPERCILEX
Copy link
Collaborator

NP! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
2 participants
@samtstern @SUPERCILEX