Skip to content

[Internal] Kill our custom baseline textview #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SUPERCILEX opened this issue Sep 27, 2018 · 7 comments
Open

[Internal] Kill our custom baseline textview #1464

SUPERCILEX opened this issue Sep 27, 2018 · 7 comments
Assignees
@samtstern
Labels
refactor
Milestone
backlog

Comments

@SUPERCILEX
Copy link
Collaborator

SUPERCILEX commented Sep 27, 2018 •
edited
Loading

This went through: material-components/material-components-android#56

Should be done when we upgrade to support lib v28 after v4.2.1.
@SUPERCILEX
Copy link
Collaborator Author

Here's the class: https://github.com/firebase/FirebaseUI-Android/blob/8bda799672d44fd2994d2498441859fae3ccb530/auth/src/main/java/com/firebase/ui/auth/util/ui/BaselineTextInputLayout.java

@samtstern samtstern added this to the 4.2.1 milestone Sep 27, 2018
@samtstern
Copy link
Contributor

@SUPERCILEX you're everywhere! SGTM

@samtstern samtstern modified the milestones: 4.2.1, 4.3.0 Oct 23, 2018
@samtstern
Copy link
Contributor

Upgrading to compile SDK 28 gave me some weird build issues, so will deal with this in 4.3.0 (which will come soon after 4.2.1).

@samtstern samtstern self-assigned this Nov 19, 2018
@samtstern samtstern mentioned this issue Nov 19, 2018
Merged
@samtstern
Copy link
Contributor

This has been released in version 4.3.0.

@samtstern samtstern reopened this Jan 2, 2019
@samtstern
Copy link
Contributor

Looking at TextInputLayout.class in the 28.0.0 release of the design support library, I don't think your change made it in :-/

@SUPERCILEX
Copy link
Collaborator Author

Huh, I guess it's only available in AndroidX. Maybe it's time to do the migration?

@samtstern
Copy link
Contributor

Yeah one of many reasons! I guess we have to just swallow that pill soon.

@samtstern samtstern modified the milestones: 4.3.0, 4.3.2 Jan 18, 2019
@samtstern samtstern modified the milestones: 4.3.2, androidx Mar 25, 2019
@SUPERCILEX SUPERCILEX mentioned this issue Sep 4, 2019
Merged
4 tasks
@samtstern samtstern mentioned this issue Sep 12, 2019
Merged
@samtstern samtstern modified the milestones: 6.0.0 (androidx), backlog Sep 12, 2019
@samtstern samtstern mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samtstern samtstern

Labels
refactor
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
2 participants
@samtstern @SUPERCILEX