Skip to content

6.0.0 missing FirestoreRecyclerOptions? #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
achuinard opened this issue Sep 13, 2019 · 7 comments
Closed

6.0.0 missing FirestoreRecyclerOptions? #1676

achuinard opened this issue Sep 13, 2019 · 7 comments
Assignees
Milestone

Comments

@achuinard
Copy link

Welcome to FirebaseUI and thanks for submitting an issue!

Please take a look at open issues, as well as resolved issues, to see if your issue is either already being addressed, or has been solved by someone else.

If not, please feel free to fill in the following info so we can help faster!

Step 1: Are you in the right place?

  • For issues or feature requests related to the code in this repository file a GitHub issue.
  • For general technical questions, post a question on StackOverflow tagged appropriately.
  • For general Firebase discussion, use the firebase-talk google group
  • For help troubleshooting your application that does not fall under one of the above categories, reach out to the personalized Firebase support channel

Step 2: Describe your environment

  • FirebaseUI version: 6.0.0

Step 3: Describe the problem:

App will not compile, says FirestoreRecyclerOptions doesn't exist as a class.

Steps to reproduce:

Upgrade to 6.0.0 in your build.gradle.

Observed Results:

It doesn't compile.

Expected Results:

I wanted the app to compile.

@akselwillgert
Copy link

I see the same, some files are missing from the downloaded .aar
missingfiles

@samtstern
Copy link
Contributor

@achuinard @willgurht thank you for reporting! This is ... not good. I will have to take a look.

@samtstern samtstern added this to the 6.0.1 milestone Sep 13, 2019
@samtstern
Copy link
Contributor

OK I used dex-member-list to analyze the members of firestore 5.1.0 vs 6.0.0 and this is the diff:
http://www.mergely.com/NlVBQrgZ/

There are a lot of missing classes (FirestoreArray, FirestoreRecyclerOptions) but also some very suspicious missing methods like FirestoreRecyclerAdapter.updateOptions ... I have no idea what's going on here but it's definitely a real issue!

@samtstern
Copy link
Contributor

Working on this in #1678, once it's merged we will have a SNAPSHOT build for you to test.

@samtstern
Copy link
Contributor

Ok this has been fixed in 6.0.1. Let me know if you see any issues!

@achuinard
Copy link
Author

Thanks @samtstern. Just waiting on 6.0.2 first though...

@samtstern
Copy link
Contributor

That's coming today, thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants