Preserve unused classes #1678
Merged
Preserve unused classes #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I59f179e31da39ad1b3cd80a5c514187978a0fa5e
Change-Id: I72bc7d7bcd4ee9d1deca5d3da38bd7dfac83a5b2
|
Talked to @SUPERCILEX on chat, this is his suggestion so I have approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1676
For version 6.0.0 we went from AGP 3.2.1 to AGP 3.5.0, looks like the R8 enablement in 3.4.0 got us:
https://developer.android.com/studio/build/shrink-code#configuration-files
Here's how Firestore's dex methods list looks after this change (left is 5.1.0, right is this commit);
http://www.mergely.com/W2XBd87e/
Looks correct to me.