Skip to content

Release Build Crash after Updating to 6.0.2 #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zjamshidi opened this issue Sep 21, 2019 · 7 comments
Closed

Release Build Crash after Updating to 6.0.2 #1686

zjamshidi opened this issue Sep 21, 2019 · 7 comments

Comments

@zjamshidi
Copy link

zjamshidi commented Sep 21, 2019

I just updated to FirebaseUI 6.0.2. Debug build works fine but release build crashes.

java.lang.RuntimeException: Facebook provider cannot be configured without dependency. Did you forget to add 'com.facebook.android:facebook-login:VERSION' dependency?

I have already included facebook login in .gradle file:

    implementation 'com.firebaseui:firebase-ui-auth:6.0.2'
    implementation 'com.facebook.android:facebook-login:5.5.1'

I downgraded to FirebaseUI version 5 again to resolve the crashes. Do you have any solution for it? Should I add anything to progaurd?

@samtstern
Copy link
Contributor

samtstern commented Sep 23, 2019 via email

@zjamshidi
Copy link
Author

I tried the following dependecies:

    implementation 'com.firebaseui:firebase-ui-auth:6.0.2'
    implementation 'com.facebook.android:facebook-login:4.41.0'

and again got the crash:

java.lang.RuntimeException: Facebook provider cannot be configured without dependency. Did you forget to add 'com.facebook.android:facebook-login:VERSION' dependency?

When I disabled the progaurd it works fine. Here is the progaurd's rules:

-keepattributes SourceFile,LineNumberTable

-renamesourcefileattribute SourceFile

-keepattributes *Annotation*

-keep class com.crashlytics.** { *; }
-dontwarn com.crashlytics.**

-keep class com.revenuecat.purchases.** { *; }

Should I add any thing to progaurd rules?

@akselwillgert
Copy link

akselwillgert commented Sep 25, 2019

In 6.02 i had to add

# Keep the class names used to check for availablility
-keepnames class com.facebook.login.LoginManager

I guess AuthUI proguard file isnt applied properly since the update or rather, not at all. :)

It used to be:
consumerProguardFiles("auth-proguard.pro")
But now:
consumerProguardFiles("proguard-rules.pro")

@samtstern
Copy link
Contributor

samtstern commented Sep 28, 2019

@willgurht thank you for sharing the fix! That seems like the likely culprit, we had to change our proguarding after 6.0.0 so I bet the consumer rules got lost.

@samtstern samtstern added this to the 6.0.3 milestone Sep 28, 2019
@zjamshidi
Copy link
Author

Thanks @willgurht
I will wait for the fix in 6.0.3

@hkchakladar
Copy link

Also facing this issue due to pro-guard.

@samtstern
Copy link
Contributor

This has been released in FirebaseUI 6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants