FirebaseArray's Limited Access Modifiers

[WillieCubed]

I'm trying to create an addon to FirebaseUI; this addon includes the FirebaseSpinnerAdapter I proposed in #304 for this library. @puf suggested I put it in a separate library, thus I created the FirebaseUI-Android-Addons repository.
It (for now) includes the FirebaseSpinnerAdapter, but I ran into a problem during implementation: I had to create a copy of the FirebaseArray for a future feature since the one FirebaseUI provides is package-private.

I was wondering if I could submit a PR to change that since my problem would be fixed with some SOLID programming.

[SUPERCILEX]

@puf I don't see the harm in making FirebaseArray public. mSnapshots is still private so I don't see how using FirebaseArray could lead to unexpected behavior.

[puf]

You can currently use FirebaseArray in your own adapters by putting them in
the same package, which is how FirebaseUI's adapters do it.

We've so far steered away from making FirebaseArray part of the public
contract of the library. The reasoning is that we'd be supporting its API
contract and guaranteeing backwards compatibility. While we may (and
probably should) at some point do that, I'd prefer to push that moment out
a bit further if possible.

On Sat, Oct 8, 2016 at 11:13 PM Alex Saveau notifications@github.com
wrote:

@puf https://github.com/puf I don't see the harm in making FirebaseArray
public. mSnapshots is still private so I don't see how using FirebaseArray
could lead to unexpected behavior.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#337 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3w3-pSjaGi-LBFskDvzyfwhA7cOXV0ks5qyAeOgaJpZM4KMKhq
.

[samtstern]

#544 has been merged. You can check out the version-2.0.0-dev branch and play around if you're curious.

[WillieCubed]

Thanks!