Skip to content

Audit all uses of IdentityProviders constants #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samtstern opened this issue Oct 17, 2016 · 1 comment
Closed

Audit all uses of IdentityProviders constants #361

samtstern opened this issue Oct 17, 2016 · 1 comment
Assignees
@amandle
Labels
auth fix-implemented refactor
Milestone
1.0.0

Comments

@samtstern
Copy link
Contributor

See #356, when adding Twitter we clearly missed a few spots. The safest thing to do here is check every time the GOOGLE or FACEBOOK constants are referenced and then make sure TWITTER is also referenced in appropriate.

In the long term, the responsibility should probably be inverted so that we don't have to go hunting through the codebase each time an IDP is added.
@samtstern samtstern added this to the 1.0.0 milestone Oct 17, 2016
amandle added a commit that referenced this issue Oct 19, 2016
@amandle
Audit for missed instances of Twitter (#366)
fd4de5a 
Resolves issue #361
@amandle
Copy link
Contributor

amandle commented Oct 19, 2016

Resolved with #366

@amandle amandle closed this as completed Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amandle amandle

Labels
auth fix-implemented refactor
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@amandle @samtstern