-
Notifications
You must be signed in to change notification settings - Fork 1.9k
setTosUrl() only shows a ToS URL in the email SignUp #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@nathanvogel while I can't discuss legal issues (I am not a lawyer) we can talk about this feature request. Where else would you like the ToS shown? When using a non-Firebase Identity Provider (such as Google or Facebook) we launch directly into the flow of that provider. In most cases these providers show their own terms of service when appropriate (generally on the first sign-in attempt). In most Android apps I use I don't see any other ToS links when signing in with a third-party Identity Provider. |
Yes we're being extra-cautious on the legal side. In a test case (creating a new MyApp account from a Google account), after tapping Sign In With Google the only dialog that was shown was the Google Account selection screen. No OAuth dialog, no authorization dialog, nothing. I was logged right into the app with a fresh account. So I see only two possibilities :
Both only if custom ToS are supplied and maybe if a "showTosWithAllProviders" option is set. I prefer the second option and can't think of another one right now, beside letting the developer handle non-Firebase Providers, but it doesn't feel right in respect to the .setTosUrl() function. |
I liked the idea of a |
@eirikvaa there hasn't been any progress on this, mainly because of the questionable UX. A dialog is not ideal, and there are so many paths to sign in with FirebaseUI it would be almost impossible to show a ToS during all of them. We show a ToS during the email and phone flows because we own the whole UI. For Facebook / Google / etc we just call out to their UI, and they almost always have links to a privacy policy or ToS for their service. |
@samtstern Ok, that makes sense. Thanks for the quick reply! |
What about small text below buttons "By signing in you accept our ToS and PP" with clickable links? I've added my own layout by creating file |
I think it would be a good idea to show both URLs for the privacy policy and TOS in the screen where you get to pick how to log in, like it's done with the setLogo method. This way the user can check the contents of each of those regardless of which provider they want to use. |
I've followed the example code for the Phone Authentication (I do not need email auth), but I cannot see the Tos and privacy. This is my code:
Have I missed something? ---- EDIT The message say that by tapping on Continue the user accept ToS and PP, but the whole step is automatic and users do not need to tap the button. |
I use only Google and Facebook providers and used |
I just ran in to this issue in an app that I'm working on and my first thought was that the way ToS and PP is handled can't be GDPR compliant and if it isn't then anyone with users in the EU will be in violation and could face some hefty fines |
Ok so there are a few things here:
I think (1) is a little difficult to do in a visually attractive way as the bottom of the screen is very busy already. (2) seems like an easy win. |
The Twitter and Facebook logins already show a PP and ToS if you provide it, but Google doesn't. If the Google login could show those, it would make #1 unnecessary and remove the edge case where only one provider doesn't go through the picker activity. |
Note that this is a legal issue. I have just received a mail from Google warning me that my app (using Firebase-UI) is in violation:
Note that I do provide a Privacy Policy, but this is shown in the about (not before login). Therefor this is a welcome feature (that should be independent from the provider type). |
@samtstern This issue can be closed. |
As mentioned by SUPERCILEX in #483, the Terms of Service URL only shows up in the email sign up flow. This can be problematic from a legal point of view.
(a legal explanation : https://termsfeed.com/blog/add-i-agree-terms-checkbox/ )
I'm creating this issue, because it should at least be clearly explained in the documentation, but I think that it should also appear with other providers, since this can pose actual legal issues.
FirebaseUI version: 1.0.1
The text was updated successfully, but these errors were encountered: