Skip to content

Wrong colors used in AuthUI when Night Mode enabled #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
the-dagger opened this issue Jan 9, 2017 · 8 comments
Closed

Wrong colors used in AuthUI when Night Mode enabled #502

the-dagger opened this issue Jan 9, 2017 · 8 comments

Comments

@the-dagger
Copy link
Contributor

  • Android device: OnePlus 3
  • Android OS version: 7.0
  • Google Play Services version: 10.0.84
  • Firebase/Play Services SDK version: 10.0.1
  • FirebaseUI version: 1.0.1

Step 3: Describe the problem:

Steps to reproduce:

  1. Set the default app theme as dark AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
  2. Try logging in via email

Observed Results:

The TextColor in EditText was black

Expected Results:

The TextColor in EditText should be white, or a light color

Relevant Code:

screenshot_20170110-021308
screenshot_20170110-021258

@samtstern
Copy link
Contributor

Let's keep this open and 'fix-implemented' until the release goes out.

@the-dagger
Copy link
Contributor Author

Sure, sounds good. 👍

@samtstern
Copy link
Contributor

@the-dagger unfortunately I had to revert this change (in #515) since this was making the EditText colors wrong in all non-dark situations. Rather than try to make it work in both cases, I went for the revert strategy for max safety for the 1.1.0 release.

Happy to try and get this in for the 1.2.0 release.

@the-dagger
Copy link
Contributor Author

@samtstern Thanks for pointing it out.
I'll see what caused this issue.

@the-dagger
Copy link
Contributor Author

@samtstern Should i push the fix to 1.1.0-dev?

@samtstern
Copy link
Contributor

@the-dagger yes create a PR with that as the base branch and I will review it.

@the-dagger
Copy link
Contributor Author

the-dagger commented Jan 12, 2017 via email

@samtstern
Copy link
Contributor

The fix for this issue has been released in v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants