-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Wrong colors used in AuthUI when Night Mode enabled #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Let's keep this open and 'fix-implemented' until the release goes out. |
Sure, sounds good. 👍 |
@the-dagger unfortunately I had to revert this change (in #515) since this was making the EditText colors wrong in all non-dark situations. Rather than try to make it work in both cases, I went for the revert strategy for max safety for the 1.1.0 release. Happy to try and get this in for the 1.2.0 release. |
@samtstern Thanks for pointing it out. |
@samtstern Should i push the fix to 1.1.0-dev? |
@the-dagger yes create a PR with that as the base branch and I will review it. |
Sure, thanks
|
The fix for this issue has been released in |
Step 3: Describe the problem:
Steps to reproduce:
AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
Observed Results:
The TextColor in EditText was black
Expected Results:
The TextColor in EditText should be white, or a light color
Relevant Code:
The text was updated successfully, but these errors were encountered: