Don't show hard-to-use IDPs for Smart Lock sign-in #1166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
samtstern
reviewed
Feb 26, 2018
| if (providerId.equals(GoogleAuthProvider.PROVIDER_ID) | ||
| || providerId.equals(FacebookAuthProvider.PROVIDER_ID) | ||
| || providerId.equals(TwitterAuthProvider.PROVIDER_ID)) { | ||
| if (providerId.equals(GoogleAuthProvider.PROVIDER_ID)) { |
There was a problem hiding this comment.
nit: can we change the name of this method to be "getCredentialAccountTypes" or something that implies it has to do with SmartLock?
|
@SUPERCILEX thanks for this! I guess this would make the next release |
Signed-off-by: Alex Saveau <[email protected]>
|
Yup, SGTM |
|
@SUPERCILEX I am actually going to bump this off of This way we can keep this bug-fix release as a true bug-fix release. |
|
Yeah, SGTM. 👍 |
samtstern
changed the base branch from
version-3.2.2-dev
to
version-3.3.0-dev
|
@samtstern Is this ready to roll? |
|
@SUPERCILEX kept forgetting about this one, but good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1154