Update dependencies #1203
Merged
Update dependencies #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
samtstern
reviewed
Mar 23, 2018
constants.gradle
Outdated
| minSdk = 14 | ||
|
|
||
| firebaseVersion = '11.8.0' | ||
| firebaseVersion = '12.0.0' |
There was a problem hiding this comment.
Let's wait for 12.0.1 ... 12.0.0 turned out to be kinda broken by some wayward ProGuard.
There was a problem hiding this comment.
Yeah, I just saw your other comment. SGTM!
There was a problem hiding this comment.
@samtstern Can you also unmark the CredentialsClient as @Hide? That makes lint think we're not allowed to use its methods... pretty sure you guys only meant to mark the constructors as @Hide 😄.
|
That's another 12.0.0 bug, it's getting fixed.
…On Fri, Mar 23, 2018 at 12:33 PM Alex Saveau ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In constants.gradle
<#1203 (comment)>
:
> @@ -8,7 +8,7 @@ project.ext {
targetSdk = 27
minSdk = 14
- firebaseVersion = '11.8.0'
+ firebaseVersion = '12.0.0'
@samtstern <http:///samtstern> Can you also unmark the CredentialsClient
as @hide? That makes lint think we're not allowed to use its methods...
pretty sure you guys only meant to mark the constructors as @hide 😄.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1203 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEw6sVMiSMumVCKQfO2uzwm2Wo4EHpoks5thU30gaJpZM4S5DdW>
.
|
|
Awesome sauce! |
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
|
@SUPERCILEX 12.0.1 is out, so we should be able to update this, merge it, and release |
# Conflicts: # constants.gradle
Signed-off-by: Alex Saveau <[email protected]>
|
@SUPERCILEX looks like |
|
Sweet, I was just about to tell you I don't have my laptop with me, thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12!