Remove a ton of redundant code#1207
Merged
samtstern merged 2 commits intofirebase:version-3.3.0-devfrom Mar 26, 2018
SUPERCILEX:redundent
Merged
Remove a ton of redundant code#1207samtstern merged 2 commits intofirebase:version-3.3.0-devfrom SUPERCILEX:redundent
samtstern merged 2 commits intofirebase:version-3.3.0-devfrom
SUPERCILEX:redundent
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
This was referenced Mar 25, 2018
Merged
samtstern
reviewed
Mar 26, 2018
|
|
||
| @Override | ||
| public final void onChanged(Resource<T> resource) { | ||
| if (resource.getState() == State.LOADING) { |
Contributor
There was a problem hiding this comment.
This will make it really easy to remove all the dialogs later! Since now we can just handle loading in some other way.
Contributor
|
@SUPERCILEX nice! Btw let's cut off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@samtstern We're on the last mile for my rewrite auth PR! There's email and phone left, but I'm going to be busy next week again so I'm hoping get all my PRs open by the end of this weekend. Email will be easy, but phone literally required a complete rewrite. Sorry in advance! 😊
This PR is starting to rip out all the leftover changes I haven't merged in yet. Also went ahead and fixed #1205 while I was at it.