-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Version 3.3.1 #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.3.1 #1258
Conversation
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Change-Id: Iad8aefb2558f8e52f3a6fbc0045daef5fe1a33bd
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
…ocial providers (#1243)
Change-Id: Ia416b5237d98bc09952828930a1638436c3955a6
Change-Id: I41c587a3b394316d2216a4466ddb3b1a1b717230
Change-Id: I3d67b54b137faf9bbf62fdba21ec19d7499a2284
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@SUPERCILEX since there are no more open issues in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM!
I'll take another look at your paging PR so we can hopefully get that merged today. 👍
@samtstern Actually, wait a sec: should we be forcing people to upgrade to Play Services 15.0.0? It signs everybody out so I'm not sure if we'd want to force that upon a FUI bugfix release. |
Oh, too late 😆 Dunno if you released yet... |
@SUPERCILEX Sorry to ask, but this does not include the silent sign in yet? |
@GuanacoDevs no, but 3.4 will. As for the support library not being updated, laziness? 😋 Feel free to bump up to 27.1.1. |
@SUPERCILEX yeah I did release. As a policy we always keep FUI updated to the latest play services at the time of release ... but I can see your point! And yes: I just didn't know that |
No description provided.