Skip to content

Version 3.3.1 #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 16, 2018
Merged

Version 3.3.1 #1258

merged 31 commits into from
Apr 16, 2018

Conversation

samtstern
Copy link
Contributor

No description provided.

SUPERCILEX and others added 30 commits March 25, 2018 16:25
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Change-Id: Iad8aefb2558f8e52f3a6fbc0045daef5fe1a33bd
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Signed-off-by: Alex Saveau <[email protected]>
Change-Id: Ia416b5237d98bc09952828930a1638436c3955a6
Change-Id: I81f13f8a573c80f77ff596139fe7589e86d9ee58
Change-Id: I41c587a3b394316d2216a4466ddb3b1a1b717230
Change-Id: I3d67b54b137faf9bbf62fdba21ec19d7499a2284
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@samtstern
Copy link
Contributor Author

@SUPERCILEX since there are no more open issues in the 3.3.1 milestone I am proposing to release 3.3.1 today and then we can move on to 3.4.0 development. Sound good?

@samtstern samtstern added this to the 3.3.1 milestone Apr 16, 2018
Copy link
Collaborator

@SUPERCILEX SUPERCILEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

I'll take another look at your paging PR so we can hopefully get that merged today. 👍

@samtstern samtstern merged commit 4bedc0f into master Apr 16, 2018
@SUPERCILEX
Copy link
Collaborator

@samtstern Actually, wait a sec: should we be forcing people to upgrade to Play Services 15.0.0? It signs everybody out so I'm not sure if we'd want to force that upon a FUI bugfix release.

@SUPERCILEX
Copy link
Collaborator

Oh, too late 😆 Dunno if you released yet...

@GuanacoDevs
Copy link

GuanacoDevs commented Apr 16, 2018

@SUPERCILEX Sorry to ask, but this does not include the silent sign in yet?
It is scheduled for 3.4.0, right?
Any particular reason for the support library not being 27.1.1?

@SUPERCILEX
Copy link
Collaborator

@GuanacoDevs no, but 3.4 will. As for the support library not being updated, laziness? 😋 Feel free to bump up to 27.1.1.

@samtstern
Copy link
Contributor Author

@SUPERCILEX yeah I did release. As a policy we always keep FUI updated to the latest play services at the time of release ... but I can see your point!

And yes: I just didn't know that 27.1.1 was available. Whoops!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants