Skip to content

fix snapshot gradle implementation typo #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2018
Merged

Conversation

frapeti
Copy link
Contributor

@frapeti frapeti commented May 22, 2018

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • Run ./gradlew check to ensure the Travis build passes.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

@frapeti frapeti requested a review from samtstern as a code owner May 22, 2018 14:29
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@samtstern
Copy link
Contributor

@frapeti thanks for this! If you don't want to sign the CLA for a one-line change just let me know and I will make this change for you.

Worth noting that signing the CLA is a one-time thing for all Google repos though.

@frapeti
Copy link
Contributor Author

frapeti commented May 22, 2018

@samtstern just signed the CLA 🙂

@googlebot
Copy link

CLAs look good, thanks!

@samtstern
Copy link
Contributor

Uhhh, seems like I just locked myself out of the house:
image

@samtstern samtstern merged commit 48c625b into firebase:master May 23, 2018
@samtstern
Copy link
Contributor

@frapeti thanks for your help and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants