Skip to content

Include/exclude countries from the country selector list in phone authentication #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtstern merged 11 commits into from
May 30, 2018
Merged

Include/exclude countries from the country selector list in phone authentication #1315

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fc6d538
Adds ability to limit country selection in phone authentication
lsirac May 24, 2018
38d3ab0
Small fix
lsirac May 25, 2018
06fba95
Removes redundant country code map
lsirac May 25, 2018
e68c2b8
Small change
lsirac May 25, 2018
f34fce4
Renames CountryCodes to CountryIsos
lsirac May 25, 2018
be019cc
Adds code review suggestions
lsirac May 25, 2018
75a6e39
Adds ability to input country code as well as iso
lsirac May 25, 2018
6d2011e
Renames new methods
lsirac May 26, 2018
545a90a
Small fix
lsirac May 27, 2018
d41c901
Applies review suggestions
lsirac May 29, 2018
9051b55
Country code to iso map is initialized only when needed
lsirac May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 124 additions & 10 deletions auth/src/main/java/com/firebase/ui/auth/AuthUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
import java.util.HashSet;
import java.util.IdentityHashMap;
import java.util.List;
import java.util.Locale;
import java.util.Set;

/**
Expand Down Expand Up @@ -214,9 +215,9 @@ public static int getDefaultTheme() {
* Signs the user in without any UI if possible. If this operation fails, you can safely start a
* UI-based sign-in flow knowing it is required.
*
* @param context requesting the user be signed in
* @param configs to use for silent sign in. Only Google and email are currently
* supported, the rest will be ignored.
* @param context requesting the user be signed in
* @param configs to use for silent sign in. Only Google and email are currently supported, the
* rest will be ignored.
* @return a task which indicates whether or not the user was successfully signed in.
*/
@NonNull
Expand Down Expand Up @@ -643,10 +644,123 @@ public PhoneBuilder setDefaultCountryIso(@NonNull String iso) {
throw new IllegalStateException("Invalid country iso: " + iso);
}

getParams().putString(ExtraConstants.COUNTRY_ISO, iso);
getParams().putString(ExtraConstants.COUNTRY_ISO,
iso.toUpperCase(Locale.getDefault()));

return this;
}


/**
* Sets the country codes available in the country code selector for phone
* authentication. This is not to be called with
* {@link #setBlacklistedPhoneAuthCountryCodes(List<String>)}.
* If both are called, an exception will be thrown.
* <p>
* For a list of country codes, see Alpha-2 codes here:
* http://www.nationsonline.org/oneworld/country_code_list.htm
*
* @param whitelistedPhoneAuthCountryCodes a case insensitive list of country codes to
* be whitelisted
*/
public PhoneBuilder setWhitelistedPhoneAuthCountryCodes(
@NonNull List<String> whitelistedPhoneAuthCountryCodes) {
if (getParams().containsKey(ExtraConstants.BLACKLISTED_COUNTRY_CODES)) {
throw new RuntimeException(
"You can either whitelist or blacklist country codes for phone " +
"authentication.");
}

addCountryCodesToBundle(whitelistedPhoneAuthCountryCodes,
ExtraConstants.WHITELISTED_COUNTRY_CODES);
return this;
}

/**
* Sets the country codes to be removed from the country code selector for phone
* authentication. This is not to be called with
* {@link #setWhitelistedPhoneAuthCountryCodes(List<String>)}.
* If both are called, an exception will be thrown.
* <p>
* For a list of country codes, see Alpha-2 codes here:
* https://en.wikipedia.org/wiki/ISO_3166-1
*
* @param blacklistedPhoneAuthCountryCodes a case insensitive list of country codes to
* be whitelisted
*/
public PhoneBuilder setBlacklistedPhoneAuthCountryCodes(
@NonNull List<String> blacklistedPhoneAuthCountryCodes) {
if (getParams().containsKey(ExtraConstants.WHITELISTED_COUNTRY_CODES)) {
throw new RuntimeException(
"You can either whitelist or blacklist country codes for phone " +
"authentication.");
}

addCountryCodesToBundle(blacklistedPhoneAuthCountryCodes,
ExtraConstants.BLACKLISTED_COUNTRY_CODES);
return this;
}

private void addCountryCodesToBundle(List<String> countryCodes,
String countryCodeType) {
ArrayList<String> uppercaseCodes = new ArrayList<>();
for (String code : countryCodes) {
uppercaseCodes.add(code.toUpperCase(Locale.getDefault()));
}

getParams().putStringArrayList(countryCodeType, uppercaseCodes);
}

@Override
public IdpConfig build() {
validateInputs();
return super.build();
}

private void validateInputs() {
List<String> whitelistedCountryCodes = getParams().getStringArrayList(
ExtraConstants.WHITELISTED_COUNTRY_CODES);
List<String> blacklistedCountryCodes = getParams().getStringArrayList(
ExtraConstants.BLACKLISTED_COUNTRY_CODES);

if (whitelistedCountryCodes != null &&
blacklistedCountryCodes != null) {
throw new RuntimeException(
"You can either whitelist or blacklist country codes for phone " +
"authentication.");
} else if (whitelistedCountryCodes != null) {
validateCountryCodes(whitelistedCountryCodes);
validateDefaultCountryCode(whitelistedCountryCodes, true);

} else if (blacklistedCountryCodes != null) {
validateCountryCodes(blacklistedCountryCodes);
validateDefaultCountryCode(blacklistedCountryCodes, false);
}
}

private void validateCountryCodes(List<String> codes) {
if (codes == null) {
return;
}
for (String code : codes) {
if (!PhoneNumberUtils.isValidIso(code)) {
throw new RuntimeException("Invalid country iso code provided.");
}
}
}

private void validateDefaultCountryCode(List<String> codes,
boolean whitelisted) {
if (getParams().containsKey(ExtraConstants.COUNTRY_ISO) && codes != null) {
String defaultCode = getParams().getString(ExtraConstants.COUNTRY_ISO);
if ((codes.contains(defaultCode) && !whitelisted)
|| (!codes.contains(defaultCode) && whitelisted)) {
throw new RuntimeException("Invalid default country iso. Make sure it " +
"is either part of the whitelisted country codes or that you " +
"haven't blacklisted it.");
}
}
}
}

/**
Expand Down Expand Up @@ -679,8 +793,8 @@ public GoogleBuilder setScopes(@NonNull List<String> scopes) {
}

/**
* Set the {@link GoogleSignInOptions} to be used for Google sign-in. Standard options
* like requesting the user's email will automatically be added.
* Set the {@link GoogleSignInOptions} to be used for Google sign-in. Standard
* options like requesting the user's email will automatically be added.
*
* @param options sign-in options
*/
Expand Down Expand Up @@ -784,8 +898,8 @@ private abstract class AuthIntentBuilder<T extends AuthIntentBuilder> {
boolean mEnableHints = true;

/**
* Specifies the theme to use for the application flow. If no theme is specified, a default
* theme will be used.
* Specifies the theme to use for the application flow. If no theme is specified, a
* default theme will be used.
*/
@NonNull
public T setTheme(@StyleRes int theme) {
Expand Down Expand Up @@ -825,8 +939,8 @@ public T setPrivacyPolicyUrl(@Nullable String privacyPolicyUrl) {
}

/**
* Specified the set of supported authentication providers. At least one provider must be
* specified. There may only be one instance of each provider.
* Specified the set of supported authentication providers. At least one provider must
* be specified. There may only be one instance of each provider.
* <p>
* <p>If no providers are explicitly specified by calling this method, then the email
* provider is the default supported provider.
Expand Down
Loading