Skip to content

Insane full build perf improvements #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Insane full build perf improvements #1386

merged 1 commit into from
Jul 4, 2018

Conversation

SUPERCILEX
Copy link
Collaborator

@SUPERCILEX SUPERCILEX commented Jul 3, 2018

The proguard-tests module was running a full optimize routine which isn't necessary to check our proguard config. Our Travis builds are faster by 5-10 minutes! 💯
image

@SUPERCILEX SUPERCILEX requested a review from samtstern as a code owner July 3, 2018 02:05
@samtstern
Copy link
Contributor

Wow! Saw this PR subject and even on vacation I couldn't resist.

@samtstern samtstern merged commit 0c13d77 into firebase:version-4.2.0-dev Jul 4, 2018
@SUPERCILEX SUPERCILEX deleted the patch-1 branch July 4, 2018 20:58
@SUPERCILEX
Copy link
Collaborator Author

Haha, gotta love some good ol' clickbait. 😁 Seriously though, multi-minute improvements are basically unheard of these days. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants