Fix most Javadoc warnings #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Saveau <[email protected]>
samtstern
reviewed
Aug 27, 2018
| @@ -32,16 +33,6 @@ allprojects { | |||
| mavenLocal() | |||
| } | |||
|
|
|||
| // Skip Javadoc generation for Java 1.8 as it breaks build | |||
| if (JavaVersion.current().isJava8Compatible) { | |||
There was a problem hiding this comment.
🍺 pour one out for one of the oldest hacks in the codebase.
There was a problem hiding this comment.
Well technically I just moved it down and changed the comment, but sure, I'll take it. 😁
samtstern
reviewed
Aug 27, 2018
|
|
||
| setSource(project.the<BaseExtension>().sourceSets["main"].java.srcDirs) | ||
| classpath += files(project.the<BaseExtension>().bootClasspath) | ||
| classpath += files(project.the<LibraryExtension>().libraryVariants.map { |
There was a problem hiding this comment.
Some code is just ugly in any language haha
|
PSA: the only Javadoc warnings left are about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.