Fix small issues left in version 4.2.1#1495
Conversation
samtstern
changed the title
samtstern
left a comment
samtstern
left a comment
There was a problem hiding this comment.
Self-review to help out.
|
|
||
| @Override | ||
| public int getSectionForPosition(int position) { | ||
| if (sections == null) { |
There was a problem hiding this comment.
Since we were using "fast scrolling" this method had to be implemented to get the scroll bar to work correctly.
There was a problem hiding this comment.
I tested this, and it seems a bit jumpy. If you scroll all the way down, and go back up, it immediately jumps to a quarter of the way up. If you can fix that, it'd be perfect. Otherwise, still a big improvement over what we had.
There was a problem hiding this comment.
The scrollbar also doesn't show up unless we start scrolling - is that the intended behavior?
There was a problem hiding this comment.
Yeah won't show up till you start scrolling, that's normal. There's nothing I can figure out to fix the jumpiness, will maybe look into it again later if people report it.
auth/src/test/java/com/firebase/ui/auth/viewmodel/PhoneProviderResponseHandlerTest.java
Show resolved
Hide resolved
| targetField = f; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit: extra space & I would name f "field" instead
auth/src/test/java/com/firebase/ui/auth/viewmodel/PhoneProviderResponseHandlerTest.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public int getSectionForPosition(int position) { | ||
| if (sections == null) { |
There was a problem hiding this comment.
I tested this, and it seems a bit jumpy. If you scroll all the way down, and go back up, it immediately jumps to a quarter of the way up. If you can fix that, it'd be perfect. Otherwise, still a big improvement over what we had.
|
|
||
| @Override | ||
| public int getSectionForPosition(int position) { | ||
| if (sections == null) { |
There was a problem hiding this comment.
The scrollbar also doesn't show up unless we start scrolling - is that the intended behavior?
lsirac
left a comment
lsirac
left a comment
There was a problem hiding this comment.
Going to approve since it's mostly just nits.
2 participants
Fixes:
Other changes:
.gradlefiles to make Android Studio pick up the build easier. I got a new computer so I was able to experience the first-timer pain.