Skip to content

Update README.md #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Update README.md #1506

merged 1 commit into from
Oct 28, 2018

Conversation

btrautmann
Copy link
Contributor

Kotlin users will need to use kapt instead of annotationProcessor or GlideApp will not be generated. Could be a bit clearer with this comment in the docs.

Note: I didn't file an issue for this since it's such a small change.

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • Run ./gradlew check to ensure the Travis build passes.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

Kotlin users will need to use `kapt` instead of `annotationProcessor` or `GlideApp` will not be generated. Could be a bit clearer with this comment in the docs.
@btrautmann btrautmann requested a review from samtstern as a code owner October 28, 2018 04:39
@samtstern
Copy link
Contributor

Thanks for this!

@samtstern samtstern merged commit 3e7fb9e into firebase:master Oct 28, 2018
brainwasheddumbass added a commit to brainwasheddumbass/FirebaseUI-Android that referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants