Skip to content

Log errors by default #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Log errors by default #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions database/src/main/java/com/firebase/ui/database/paging/FirebaseRecyclerPagingAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ public void onBindViewHolder(@NonNull VH viewHolder, int position) {
*
* When {@link DatabaseError} is caught the adapter will stop loading any data
*/
protected void onError(@NonNull DatabaseError databaseError){

protected void onError(@NonNull DatabaseError databaseError) {
Log.w(TAG, "onError", databaseError.toException());
}

@NonNull
Expand Down
2 changes: 1 addition & 1 deletion firestore/src/main/java/com/firebase/ui/firestore/paging/FirestorePagingAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,6 @@ protected void onLoadingStateChanged(@NonNull LoadingState state) {
* When {@link Exception} is caught the adapter will stop loading any data
*/
protected void onError(@NonNull Exception e) {
// For overriding
Log.w(TAG, "onError", e);
}
}