Skip to content

Fixing isNewUser #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Fixing isNewUser #1832

merged 2 commits into from
Sep 8, 2020

Conversation

laurentiu-git
Copy link
Contributor

Hey there!
I want to share my fix for the issue #1737 , I was able to get the expected result for isNewUser when user signs in with Twitter, but I was not able to sign in with Microsoft, I'm not sure if it's because of my setup it's wrong or it's something else.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@laurentiu-git
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 8, 2020
@samtstern
Copy link
Contributor

@laurentiu-git thanks for this! Looks like a simple and safe change.

@samtstern samtstern merged commit c94ac88 into firebase:version-6.4.0-dev Sep 8, 2020
@samtstern samtstern added this to the 6.4.0 milestone Sep 8, 2020
samtstern added a commit that referenced this pull request Sep 8, 2020
@laurentiu-git laurentiu-git deleted the fixing-1737 branch September 8, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants