Skip to content

Fix to allow bolding of text that coincides with the end of body. #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2020
Merged

Fix to allow bolding of text that coincides with the end of body. #1840

merged 2 commits into from
Sep 29, 2020

Conversation

ElectricMagic
Copy link
Contributor

textToBold that is a suffix of text would be rejected by the end>=text.length test.
end > text.length() is the correct indication that text.indexof gave us a bogus offset.

@samtstern samtstern changed the base branch from master to version-6.4.0-dev September 29, 2020 11:35
@samtstern samtstern added this to the 6.4.0 milestone Sep 29, 2020
@samtstern samtstern merged commit 25dea9d into firebase:version-6.4.0-dev Sep 29, 2020
@samtstern
Copy link
Contributor

@ElectricMagic thanks for the PR! Merged into the 6.4.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtstern samtstern Awaiting requested review from samtstern

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ElectricMagic @samtstern @googlebot