Skip to content

Switch to AppCompatButton compound drawables in auth provider buttons #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2020
Merged

Switch to AppCompatButton compound drawables in auth provider buttons #1861

merged 2 commits into from
Nov 9, 2020

Conversation

AryanNajafi
Copy link
Contributor

@AryanNajafi AryanNajafi commented Nov 9, 2020 •
edited by samtstern
Loading

See #1860

@google-cla google-cla bot added the cla: yes label Nov 9, 2020
@samtstern
Copy link
Contributor

@AryanNajafi thank you! Can you add line to CHANGELOG.md like this:

- [Auth] Remove SupportVectorDrawablesButton (#1860) (contributed by @AryanNajafi)

@samtstern samtstern added this to the 7.0.0 milestone Nov 9, 2020
@samtstern samtstern merged commit 5342e3d into firebase:version-7.0.0-dev Nov 9, 2020
samtstern added a commit that referenced this pull request Dec 1, 2020
@samtstern
Revert "Switch to AppCompatButton compound drawables in auth provider…
0fecbb0 
… buttons (#1861)"

This reverts commit 5342e3d.
@samtstern samtstern mentioned this pull request Dec 1, 2020
Merged
samtstern added a commit that referenced this pull request Dec 1, 2020
@samtstern
Revert "Switch to AppCompatButton compound drawables in auth provider…
dea9a7e 
… buttons (#1861)" (#1875)

This reverts commit 5342e3d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtstern samtstern samtstern approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AryanNajafi @samtstern