Skip to content

Conversation

@samtstern
Copy link
Contributor

@samtstern samtstern commented Mar 24, 2021

Fixes #1910

TODO:

  • POM generation
  • Get rid of nasty centralized build
  • Publishing instructions
  • Check that publishing actually works

Note, this changes how dependencies that come from the Firebase BOM are reflected in the pom.xml, however this seems to be more correct based on the docs here:
http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#importing-dependencies

Before

  <dependencies>
    <dependency>
      <groupId>com.firebaseui</groupId>
      <artifactId>firebase-ui-common</artifactId>
      <version>7.1.1</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>com.google.firebase</groupId>
      <artifactId>firebase-database</artifactId>
      <version>19.5.1</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>androidx.legacy</groupId>
      <artifactId>legacy-support-v4</artifactId>
      <version>1.0.0</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>androidx.recyclerview</groupId>
      <artifactId>recyclerview</artifactId>
      <version>1.1.0</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>

After

  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>com.google.firebase</groupId>
        <artifactId>firebase-bom</artifactId>
        <version>26.0.0</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>com.firebaseui</groupId>
      <artifactId>firebase-ui-common</artifactId>
      <version>7.1.1</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>com.google.firebase</groupId>
      <artifactId>firebase-database</artifactId>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>androidx.legacy</groupId>
      <artifactId>legacy-support-v4</artifactId>
      <version>1.0.0</version>
      <scope>compile</scope>
    </dependency>
    <dependency>
      <groupId>androidx.recyclerview</groupId>
      <artifactId>recyclerview</artifactId>
      <version>1.1.0</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>

@google-cla google-cla bot added the cla: yes label Mar 24, 2021
@@ -1,17 +1,9 @@
@file:Suppress("UnstableApiUsage")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye to most of this rats nest!

@samtstern samtstern merged commit 4455f41 into master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload artifacts to Maven Central

1 participant