Have FirebaseArray accessible from subclasses

[davideno]

Problem:
Currently, I think, It's not possible to remove items from the FirebaseListAdapter without removing it also on firebase db.

Proposal:
I think (not sure) that having access directly to FirebaseArray would allow to create in the subclass custom adapter a method to remove items only on the adpater and not in db.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[davideno]

I signed it

[davideno]

I signed it

2016-06-29 18:15 GMT+02:00 googlebot [email protected]:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your
  GitHub username or you're using a different email address. Check your
  existing CLA data https://cla.developers.google.com/clas and verify
  that your email is set on your git commits
  https://help.github.com/articles/setting-your-email-in-git/.
• If you signed the CLA as a corporation, please let us know the
  company's name.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#205 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AQRti3CYP50o9eH6nJmQROaOuxZjgobHks5qQporgaJpZM4JBT1o
.

[puf]

Thanks for the PR. We had some good reasons behind not making the FirebaseArray accessible to sub-classes.

Can you open an issue (that's in general recommended before opening a PR) and give some more examples of how you'd use the array in your subclasses?

[davideno]

Hi @puf
I created the issue FirebaseArray in FirebaseListAdapter is not accessible from subclasses #206