Password visibility toggle fix #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change LGTM. @amandle what do you think? Also I propose if we merge this we do a |
|
LGTM, a |
|
0.6.1 released |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a pain. In the end, I had to resort to just adding a workaround which sucks because the current implementation has a glitch where when you toggle visibility, the cursor position resets. Anyway, I created an AOSP issue for the desing lib: https://code.google.com/p/android/issues/detail?id=224914&thanks=224914&ts=1476159232
Back to the PR though, I upgraded gradle dependencies and removed appcompat-v7 which we weren't using. We're using the design lib. I also changed the style of two edittexts that should have been passwords.
#347