Return tokens on successful sign in with an IDP #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
approved these changes
Oct 18, 2016
| /** | ||
| * Get the email used to sign in. | ||
| */ | ||
| public String getEmail() { |
There was a problem hiding this comment.
NonNull? Also is there any case this would not be FirebaseAuth.getInstance().getCurrentUser().getEmail()? Would prefer not to duplicate if so.
There was a problem hiding this comment.
It's actually nullable (because Twitter always has to be special). We need to record the email on the IdpResponse because we can be in the state where the user has signed in to the IDP but were unable to sign in to Firebase and we need to know the email to to find the existing account to link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the
IdpResponseobject to the user. It can be retrieved from the result intent received inonActivityResultusingIdpResponse.fromResultIntent(data). Resolves #286.