Better facebook error handling #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Oct 21, 2016
| String email = object.getString("email"); | ||
| mCallbackObject.onSuccess(createIDPResponse(loginResult, email)); | ||
| } catch (JSONException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Log.e(...) instead of e.printStackTrace().
|
One comment, LGTM to merge once that's fixed. |
|
That DDoS attack was nuts! At least GitHub is back now... Travis is going to take a while to catch up on all the backlog though. |
|
Looks like Travis is failing because of github being down intermittently I will try again later |
|
Travis passed, so merge at will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #352 and #263. Provides better error handling for Facebook Graph requests.