Refactor container activities#374
Closed
SUPERCILEX wants to merge 90 commits intofirebase:masterfrom
SUPERCILEX:containers
Closed
Refactor container activities#374SUPERCILEX wants to merge 90 commits intofirebase:masterfrom SUPERCILEX:containers
SUPERCILEX wants to merge 90 commits intofirebase:masterfrom
SUPERCILEX:containers
Conversation
won't compile
# Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/idp/IdpSignInContainer.java
Collaborator
Author
|
Again, #357 should be merged first to stay sane when reviewing this PR. There's one major roadblock that's preventing me from proceeding: Twitter only lets you receive
Thoughts? |
Collaborator
Author
|
Done refactoring |
10 tasks
Collaborator
Author
|
I just realized #418 replaces this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#254