Use support library password toggle #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

samtstern merged 1 commit into firebase:master from SUPERCILEX:pass-toggle

Nov 28, 2016

Collaborator

SUPERCILEX commented Nov 24, 2016

No description provided.


          Use support lib password toggle

9c6c15a

Collaborator Author

SUPERCILEX commented Nov 24, 2016 •

edited

Loading

There are huge benefits to doing this:

Removes a bunch of pngs
Much cleaner code (182 lines deleted vs only 21 lines added)
Fixes bug where cursor position is reset when toggling password visibility
Uses the support library so bugs will be fixed and features added

The only disadvantage I can think of:

There is no cross on the eye when the password is not visible

Contributor

samtstern commented Nov 28, 2016

This looks good to me, thanks for the simplification!

samtstern merged commit 57c850d into firebase:master

SUPERCILEX deleted the pass-toggle branch

November 28, 2016 17:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet